Use videojs-standard 5.2 and fix two errors #3508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -482,6 +483,7 @@ module.exports = function(grunt) { | |||
| ); | |||
|
|
|||
| grunt.registerTask('dist', [ | |||
| 'shell:lint', | |||
There was a problem hiding this comment.
should we lint as part of running dist?
There was a problem hiding this comment.
Hmm, probably not. Good call.
2 tasks
|
LGTM |
|
LGTM |
gkatsev
added
confirmed
and removed
needs: LGTM
misteroneill
force-pushed
the
update-standard
branch
from
1ab3c13
to
ed3285f
Compare
gkatsev
added
the
minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates to videojs-standard 5.2 or higher and fixes two errors. The benefit of the upgrade is that we get correct exit codes from the videojs-standard CLI tool so the git pre-push hook actually works to prevent invalid pushes.
Requirements Checklist